james
/
KeyV2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #148 from rsheldiii/v2/propogate-stem-inner-slop 

Correctly support $stem_inner_slop
This commit is contained in:
Bob 2022-02-21 13:29:28 -05:00 committed by GitHub
parent 4766e3eca6 08f17a4e1f
commit 41381ed376
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
customizer.scad
View File

@ -3534,7 +3534,7 @@ module rounded_cherry_stem(depth, slop, throw) {
// inside cross
// translation purely for aesthetic purposes, to get rid of that awful lattice
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
}
// a safe theoretical distance between two vertices such that they don't collapse. hard to use
@ -3734,7 +3734,7 @@ module box_cherry_stem(depth, slop, throw) {
}
// inside cross
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
}
module alps_stem(depth, slop, throw){
@ -4098,12 +4098,12 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "rounded_cherry") {
difference() {
cylinder(d=$rounded_cherry_stem_d * 2, h=stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "box_cherry") {
difference() {
@ -4113,7 +4113,7 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "cherry_stabilizer") {
difference() {
@ -4123,7 +4123,7 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if(stem_type == "choc") {
translate([-5.7/2,0,0]) linear_extrude(height=stem_support_height) {
@ -4372,7 +4372,7 @@ module tines_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "cherry_stabilizer") {
difference () {
@ -4392,13 +4392,13 @@ module tines_support(stem_type, stem_support_height, slop) {
difference () {
centered_tines(stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "rounded_cherry") {
difference () {
centered_tines(stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "alps"){
centered_tines(stem_support_height);

8
src/stem_supports/brim.scad
View File

@ -16,12 +16,12 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "rounded_cherry") {
difference() {
cylinder(d=$rounded_cherry_stem_d * 2, h=stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "box_cherry") {
difference() {
@ -31,7 +31,7 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "cherry_stabilizer") {
difference() {
@ -41,7 +41,7 @@ module brim_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if(stem_type == "choc") {
translate([-5.7/2,0,0]) linear_extrude(height=stem_support_height) {

6
src/stem_supports/tines.scad
View File

@ -47,7 +47,7 @@ module tines_support(stem_type, stem_support_height, slop) {
}
}
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "cherry_stabilizer") {
difference () {
@ -67,13 +67,13 @@ module tines_support(stem_type, stem_support_height, slop) {
difference () {
centered_tines(stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "rounded_cherry") {
difference () {
centered_tines(stem_support_height);
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
} else if (stem_type == "alps"){
centered_tines(stem_support_height);

2
src/stems/box_cherry.scad
View File

@ -11,6 +11,6 @@ module box_cherry_stem(depth, slop, throw) {
}
// inside cross
inside_cherry_cross(slop);
inside_cherry_cross($stem_inner_slop);
}
}