From 9842ce6ff41aaf2d6a09c1c65e0bbabb2c7bf181 Mon Sep 17 00:00:00 2001 From: Sergey Belov Date: Mon, 16 May 2022 13:51:18 +0300 Subject: [PATCH 1/2] Asa profile aligned with the Akko implementation --- src/key_profiles/asa.scad | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/key_profiles/asa.scad b/src/key_profiles/asa.scad index aaa9ede..99ab90e 100644 --- a/src/key_profiles/asa.scad +++ b/src/key_profiles/asa.scad @@ -1,13 +1,13 @@ module asa_row(row=3, column = 0) { - $key_shape_type = "sculpted_square"; - $bottom_key_height = 18.06; - $bottom_key_width = 18.05; // Default (R3) - $total_depth = 10.35; // Default (R3) +$key_shape_type = "sculpted_square"; + $bottom_key_height = 18.15; + $bottom_key_width = 18.10; // Default (R3) + $total_depth = 10.75; //! // Default (R3) $top_tilt = 1.5; // Default (R3) - $width_difference = 5.05; - $height_difference = 5.56; + $width_difference = 6.20; //! + $height_difference = 6.55; //! $dish_type = "spherical"; - $dish_depth = 1.2; + $dish_depth = 1.3; //! $dish_skew_x = 0; $dish_skew_y = 0; $top_skew = 1.75; @@ -19,24 +19,18 @@ module asa_row(row=3, column = 0) { //$rounded_key = true; if (row == 1){ - $bottom_key_width = 17.95; - $width_difference = 4.95; - $total_depth = 10.65; - $top_tilt = 7; + $total_depth = 10.5; + $top_tilt = 9.33;//4 children(); } else if (row == 2) { - $bottom_key_width = 18.17; - $width_difference = 5.17; - $total_depth = 9.65; - $top_tilt = 3.25; + $total_depth = 9.95; + $top_tilt = 4; //7 children(); } else if (row == 4){ - $bottom_key_width = 18.02; - $width_difference = 5.02; - $total_depth = 11.9; + $total_depth = 12.55; $top_tilt = 0.43; children(); - } else { + }else{ children(); - } + } } From b0eb0d030c24af051e2c4612198e1a58a913d9fd Mon Sep 17 00:00:00 2001 From: Sergey Belov Date: Mon, 16 May 2022 13:54:59 +0300 Subject: [PATCH 2/2] Update asa.scad Remove comments --- src/key_profiles/asa.scad | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/key_profiles/asa.scad b/src/key_profiles/asa.scad index 99ab90e..7dd7149 100644 --- a/src/key_profiles/asa.scad +++ b/src/key_profiles/asa.scad @@ -2,12 +2,12 @@ module asa_row(row=3, column = 0) { $key_shape_type = "sculpted_square"; $bottom_key_height = 18.15; $bottom_key_width = 18.10; // Default (R3) - $total_depth = 10.75; //! // Default (R3) + $total_depth = 10.75; // Default (R3) $top_tilt = 1.5; // Default (R3) - $width_difference = 6.20; //! - $height_difference = 6.55; //! + $width_difference = 6.20; + $height_difference = 6.55; $dish_type = "spherical"; - $dish_depth = 1.3; //! + $dish_depth = 1.3; $dish_skew_x = 0; $dish_skew_y = 0; $top_skew = 1.75; @@ -20,11 +20,11 @@ $key_shape_type = "sculpted_square"; if (row == 1){ $total_depth = 10.5; - $top_tilt = 9.33;//4 + $top_tilt = 9.33; children(); } else if (row == 2) { $total_depth = 9.95; - $top_tilt = 4; //7 + $top_tilt = 4; children(); } else if (row == 4){ $total_depth = 12.55;