From e3349308254568b7b875185bf5a663663deb99e8 Mon Sep 17 00:00:00 2001 From: Joseph Wynn Date: Wed, 21 Jun 2017 19:34:18 +0100 Subject: [PATCH] Update tests to be more descriptive; reduce test cases I've updated the `Scenario` for these to be more descriptive about what they're actually testing. I've also removed some redundant test cases (I think it's enough to test this with just one image) and used the Given-When-Then format to improve readability. --- features/save-to-source.feature | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/features/save-to-source.feature b/features/save-to-source.feature index 7f45c3a..4c0c94a 100644 --- a/features/save-to-source.feature +++ b/features/save-to-source.feature @@ -1,22 +1,18 @@ Feature: Save to source - Scenario: Save to source + Scenario: Resized images are saved to the source directory by default Given I have a responsive_image configuration with: """ - save_to_source: true sizes: - width: 100 extra_images: - assets/everybody-loves-jalapeño-pineapple-cornbread.png - - assets/*.jpeg """ And I have a file "index.html" with "Hello, world!" When I run Jekyll - And the file "assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should exist - And the file "assets/resized/progressive-100x50.jpeg" should exist + Then the file "assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should exist And the file "_site/assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should exist - And the file "_site/assets/resized/progressive-100x50.jpeg" should exist - Scenario: Do not save to source + Scenario: Resized images can be saved to the destination directory only with save_to_source: false Given I have a responsive_image configuration with: """ save_to_source: false @@ -28,7 +24,5 @@ Feature: Save to source """ And I have a file "index.html" with "Hello, world!" When I run Jekyll - And the file "assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should not exist - And the file "assets/resized/progressive-100x50.jpeg" should not exist - And the file "_site/assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should exist - And the file "_site/assets/resized/progressive-100x50.jpeg" should exist \ No newline at end of file + Then the file "assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should not exist + But the file "_site/assets/resized/everybody-loves-jalapeño-pineapple-cornbread-100x50.png" should exist